fix: apply global config globally #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-zubrienko
previously approved these changes
Apr 22, 2024
|
Will merge / release by EOW - maybe can squeeze another PR from @PJCampi on top of this one |
Co-authored-by: George Zubrienko <[email protected]>
george-zubrienko
approved these changes
Apr 25, 2024
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Apr 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) ([changelog](https://togithub.com/lidatong/dataclasses-json/releases)) | `0.6.4` -> `0.6.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lidatong/dataclasses-json (dataclasses-json)</summary> ### [`v0.6.5`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.6.5) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.6.4...v0.6.5) #### What's Changed - fix: apply global config globally by [@​PJCampi](https://togithub.com/PJCampi) in [https://github.com/lidatong/dataclasses-json/pull/524](https://togithub.com/lidatong/dataclasses-json/pull/524) - fix: support generic dataclass by [@​PJCampi](https://togithub.com/PJCampi) in [https://github.com/lidatong/dataclasses-json/pull/525](https://togithub.com/lidatong/dataclasses-json/pull/525) #### New Contributors - [@​PJCampi](https://togithub.com/PJCampi) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/524](https://togithub.com/lidatong/dataclasses-json/pull/524) **Full Changelog**: lidatong/dataclasses-json@v0.6.4...v0.6.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZTpkZXBlbmRlbmNpZXMiXX0=--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rtsscy
reviewed
May 7, 2024
| def _decode_type(type_, value, infer_missing): | ||
| if _has_decoder_in_global_config(type_): | ||
| return _get_decoder_in_global_config(type_)(value) | ||
| if is_dataclass(type_) or is_dataclass(type_): |
](https://renovatebot.com){kind=link}
There was a problem hiding this comment.
If this is a refactor from _decode_generic, would this line need to be
if is_dataclass(type_) or is_dataclass(value):
There was a problem hiding this comment.
Yes you are correct. Let me create a new PR to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the encoder/decoder registered in the global configuration